Skip to content

[Candidate Intake] Upstream PR #300 - perf: reduce repeated chat lookups and restore regressions#12

Draft
nsalvacao wants to merge 3 commits intomasterfrom
upstream-prs/pr-300
Draft

[Candidate Intake] Upstream PR #300 - perf: reduce repeated chat lookups and restore regressions#12
nsalvacao wants to merge 3 commits intomasterfrom
upstream-prs/pr-300

Conversation

@nsalvacao
Copy link

@nsalvacao nsalvacao commented Mar 16, 2026

Context

This draft PR mirrors upstream branch 'upstream-prs/pr-300' into 'master' for review, provenance, and later decision-making only.
It must not be merged wholesale. If we adopt anything from it, the intended path is commit-level intake only.

Upstream Source

Current Intake Recommendation

  • Decision: Candidate intake
  • Status: Planned review only, with no integration performed yet
  • Credit policy: preserve original author metadata, use git cherry-pick -x for any later intake, and keep any conflict adaptation in separate follow-up commits with explicit upstream attribution

Selected Commits For Any Future Intake

  • 5200afb perf: cache chat request db lookups
  • 1b5b05e fix: restore translator and cursor auto-import behavior

Skipped / Excluded Scope

  • 3378550 merge-from-master commit skipped as branch pollution.

Acceptance Gates

  • Do not merge this mirrored branch as-is.
  • If anything is adopted later, intake only the explicitly selected commits or a newly re-validated subset.
  • Preserve upstream authorship and provenance in Git history.
  • Keep conflict-resolution/adaptation commits separate from upstream-authored commits.
  • Reconfirm branch contents against current master at intake time before changing the selected scope.

Verification / Validation Checklist

  • Repeated chat lookups are reduced without changing response semantics.
  • Translator and cursor auto-import regressions are fixed.
  • Relevant core-path tests or smoke checks pass after any future intake.

Review Focus

  • Request-context caching safety in core chat paths
  • Translator and cursor auto-import regression fixes
  • Test coverage around restored behavior

Notes

  • This PR is intentionally draft and exists to support review, provenance, and later commit-level intake decisions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants